This repository has been archived by the owner on May 14, 2022. It is now read-only.
Structural Metadata Editor #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpendragon
force-pushed
the
logical_order
branch
from
f66d8c2
to
7f916f4
Compare
|
I think this is good enough to start iterating on. One easy change I think would be good is to make the "+" into a button with a label like "Add a Section" to make it more obvious. But the editing UI works well already. |
tpendragon
force-pushed
the
logical_order
branch
from
d81141e
to
4117ba0
Compare
|
Squashed commits, ready for review + merge. |
| curation_concern.save | ||
| head 200 | ||
| end | ||
|
|
There was a problem hiding this comment.
I like the naming of the methods -- I wonder if we should rename bulk_edit/save_order to match?
This feature works with the theory that structural metadata can be
abstracted into a hash that looks like the following:
```
{
"nodes": [
{
"label": "Chapter 1",
"nodes": [
{
"proxy": "mcvaa9zja"
}
]
}
]
}
```
This hash is created by the frontend with `StructureParser`, is
converted into an ordered graph by `LogicalOrder`, and can be created
from an ordered graph by `LogicalOrderGraph`.
This hash is also used to create IIIF Manifest Ranges for the viewer.
Closes #225, closes #18.
tpendragon
force-pushed
the
logical_order
branch
from
4117ba0
to
a5fa2c6
Compare
|
Sorry, late +1. I agree, this is a great start!
…-Js
Sent via mobile. Please excuse typos, brevity, etc.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature works with the theory that structural metadata can be
abstracted into a hash that looks like the following:
This hash is created by the frontend with
StructureParser, isconverted into an ordered graph by
LogicalOrder, and can be createdfrom an ordered graph by
LogicalOrderGraph.This hash is also used to create IIIF Manifest Ranges for the viewer.
Closes #225, closes #18.