Adding collections - closes #206 #245
Conversation
| describe "#validate" do | ||
| let(:errors) { double("Errors") } | ||
| before do | ||
| allow(subject).to receive(:existing_exhibit_ids).and_return(['slug1']) |
There was a problem hiding this comment.
Stubbing the object under test is usually bad joojoo. Can you go a level deeper?
There was a problem hiding this comment.
OK, I'll stub ActiveFedora::SolrService.query instead of the ids method.
There was a problem hiding this comment.
If that turns out to be too complicated, maybe a query object to encapsulate it?
|
Can we add "Create a Collection" to the front page? Maybe as the first option? |
|
"Add to Collection" from the search results view pops up a modal which seems to immediately dissapear |
escowles
force-pushed
the
collections
branch
from
589af26
to
43c5332
Compare
|
I've added a button to create a Collection to the home page, stubbed the ActiveFedora::SolrService.query method instead of the ExhibitIdValidator, and suppressed links to the broken "Add to a Collection" modal. |
|
👍 Will merge when it passes. |
|
@escowles Coverage. =( Looks like |
escowles
force-pushed
the
collections
branch
from
43c5332
to
994625b
Compare
|
Not sure why the feature test didn't cover that -- I've added a controller test to get it back to 💯 |
Adding collections - closes #206
No description provided.