Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning the header and footer CSS style rules with those of Orangelight #447

Merged
merged 2 commits into from
Nov 28, 2018

Conversation

jrgriffiniii
Copy link
Contributor

Resolves #421

@tpendragon tpendragon temporarily deployed to staging November 27, 2018 14:25 Inactive
@coveralls
Copy link

coveralls commented Nov 27, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 5316ebb on issues-421-jrgriffiniii-rebrand-header-footer into a9b5fd3 on master.

@escowles
Copy link
Member

This is a good start — I think the main other thing we should do is pull the "Digtal PUL" header into the black header bar the way that OL does with "Catalog".

@jrgriffiniii jrgriffiniii changed the title Aligning the header and footer CSS style rules with those of Orangelight [WIP] Aligning the header and footer CSS style rules with those of Orangelight Nov 27, 2018
@hackartisan
Copy link
Member

The place where it says "Digital PUL" is used on collection pages to show the collection name. So we'll need to make sure not to remove the area altogether; i guess just on index.

Ensuring that the app. name is consistently rendered in the navbar and
removing it from the masthead when no exhibit is viewed
@jrgriffiniii jrgriffiniii force-pushed the issues-421-jrgriffiniii-rebrand-header-footer branch from 28307e5 to 5316ebb Compare November 27, 2018 16:11
@jrgriffiniii jrgriffiniii changed the title [WIP] Aligning the header and footer CSS style rules with those of Orangelight Aligning the header and footer CSS style rules with those of Orangelight Nov 27, 2018
@tpendragon tpendragon temporarily deployed to staging November 27, 2018 16:15 Inactive
@jrgriffiniii
Copy link
Contributor Author

Should the responsive search input element also be resized and shifted? It seems to be significantly wider on Orangelight:

pomegranate_issues_421_screenshot_0

pomegranate_issues_421_screenshot_1

@escowles
Copy link
Member

I think it's fine to leave the search box as-is to allow more space for browse page titles.

@tpendragon tpendragon temporarily deployed to staging November 28, 2018 16:24 Inactive
@escowles escowles merged commit 314e205 into master Nov 28, 2018
@escowles escowles deleted the issues-421-jrgriffiniii-rebrand-header-footer branch November 28, 2018 16:32
@escowles escowles removed the review label Nov 28, 2018
@sdellis
Copy link
Member

sdellis commented Nov 28, 2018

I suggest using the LUX header/footer to keep it in sync with other apps.

@escowles
Copy link
Member

@sdellis I think we'll start using Lux as part of #440 — hopefully early in 2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants