Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Bender.yml by using flist and vendor deps #9

Closed
wants to merge 9 commits into from

Conversation

joennlae
Copy link

This is a version of Bender.yml that works. However, it does only use the vendored in IPs. I know kind of defying the purpose of bender but still useful for a bender pipeline when cva6 is included.

@joennlae joennlae requested a review from niwis as a code owner February 16, 2023 21:38
@niwis
Copy link
Collaborator

niwis commented Feb 17, 2023

Hi @joennlae, I opened #7 on your and @Vyeow's behalf. Feel free to modify it. I would propose using this thread for discussions on updating Bender.yml to avoid fragmentation.

Regarding this change: I think larger projects with CVA6 as a dependency might not want to be forced to use the vendored dependencies of common cells etc. But for a standalone instantiation, this might be favourable. My proposal from #7 stands: Add a target ariane_soc or similar that would include these files (however, this might require conditional dependencies).

@joennlae
Copy link
Author

Hi, @niwis. I am aware of #7. That is also why this pull request is against the bender branch and not against main. I get your point which totally makes sense.

I tried to make it work with bendered deps, but I got duplicate module declarations. Due to nonconforming versions. Which cannot be easily fixed because the others are vendored.

But I understand that we need to have the possibility. So do you want to have the ariane_soc target as the one using the vendored versions?

@niwis
Copy link
Collaborator

niwis commented Feb 17, 2023

I don't have any strong opinions on this. My main question is: is this change compatible with a system like Cheshire, which has common_cells as a dependency?

@joennlae joennlae force-pushed the bender-changes branch 2 times, most recently from afa5f5e to af0b930 Compare March 6, 2023 13:40
@niwis
Copy link
Collaborator

niwis commented Mar 7, 2023

Superseded by #11

@niwis niwis closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants