This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Drop dependency on virtualenv executable #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ichimonji10, thanks for your PR! By analyzing the history of the files in this pull request, we identified @asmacdo, @werwty and @seandst to be potential reviewers. |
|
As usual, it would be great if a Vagrant user could test this. |
dralley
approved these changes
Sep 15, 2017
Python 3.3 and newer ships with the "venv" module, which is capable of creating and managing virtualenvs. The virtualenv executable is only needed if using an older version of Python. Use `python -m venv` when creating virtualenvs. This drops the dependency on the virtualenv executable. (And whatever packages provide that executable.) Deployments of Pulp 3 will be faster and more reliable if they use code that ships with the standard library instead of third-party packages.
|
Yay! Rebased on upstream/3.0-dev and re-tested. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.3 and newer ships with the "venv" module, which is capable of
creating and managing virtualenvs. The virtualenv executable is only
needed if using an older version of Python.
Use
python -m venvwhen creating virtualenvs. This drops thedependency on the virtualenv executable. (And whatever packages provide
that executable.) Deployments of Pulp 3 will be faster and
more reliable if they use code that ships with the standard library
instead of third-party packages.