Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an OpenTelemetry profile for development purposes. #98

Merged
merged 1 commit into from
May 19, 2023

Conversation

decko
Copy link
Member

@decko decko commented Mar 3, 2023

Closes #45

@decko decko marked this pull request as draft March 3, 2023 14:10
@decko decko force-pushed the add_opentelemetry_dev_profile branch from a54f7c6 to 414222c Compare March 3, 2023 17:49
profiles/opentelemetry_dev/compose.yaml Outdated Show resolved Hide resolved
profiles/opentelemetry_dev/Containerfile Outdated Show resolved Hide resolved
@dralley
Copy link
Contributor

dralley commented Mar 3, 2023

I assume that we would be expected to use this via the using multiple environments instructions? https://github.com/pulp/oci_env#multiple-environments

@decko decko changed the title [noissue] Adds an OpenTelemetry profile for development purposes. Adds an OpenTelemetry profile for development purposes. Mar 10, 2023
@decko decko force-pushed the add_opentelemetry_dev_profile branch 2 times, most recently from 33b9a95 to cf4b68e Compare March 15, 2023 20:12
@decko decko force-pushed the add_opentelemetry_dev_profile branch 2 times, most recently from 15f9d77 to dfc4bcf Compare April 6, 2023 19:38
@decko decko marked this pull request as ready for review April 6, 2023 19:41
@decko decko closed this Apr 11, 2023
@decko decko reopened this Apr 11, 2023
@decko decko closed this Apr 19, 2023
@decko decko reopened this Apr 19, 2023
@decko decko force-pushed the add_opentelemetry_dev_profile branch from dfc4bcf to 91c5a08 Compare April 19, 2023 19:02
@decko decko requested a review from dralley April 19, 2023 19:04
@decko decko force-pushed the add_opentelemetry_dev_profile branch 6 times, most recently from 32fdad2 to 39c0712 Compare April 20, 2023 09:58
Copy link
Contributor

@ggainey ggainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some initial thoughts after getting things up and running. Will add more comments as I tink of them/run into things.

profiles/opentelemetry_dev/README.md Outdated Show resolved Hide resolved
profiles/opentelemetry_dev/README.md Show resolved Hide resolved
@decko decko force-pushed the add_opentelemetry_dev_profile branch from 39c0712 to b6d0c00 Compare April 26, 2023 14:57
@decko decko force-pushed the add_opentelemetry_dev_profile branch from b6d0c00 to 4ece734 Compare May 3, 2023 21:06
@decko decko force-pushed the add_opentelemetry_dev_profile branch 2 times, most recently from e4be476 to 7da6e09 Compare May 18, 2023 16:40
@decko decko requested a review from ggainey May 18, 2023 16:41
Copy link
Contributor

@ggainey ggainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new Examples/Tips section in docs is exactly what I was looking for!

## Examples / Tips
1. After calling `oci-env compose up` and waiting a moment for it to start up, you can access Grafana on
`http://localhost:3000`. If it is the first time you're accessing it, it will ask you to change the admin password.
After it, you can check on `Explore` section to find all the metrics collected by OpenTelemetry and sent to Prometheus.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also used this and it's worked well for me. I think if issues come up we can fix those too!

The CI failures are unrelated to this PR and intermittent. The same failures show on other PRs and the existing merged branches. To recap the convo at the working group here: Given they are unrelated to this PR, we'll rerun the CI until it passes and merge.

We need to tackle the intermittent CI failures as a separate effort.

@decko decko force-pushed the add_opentelemetry_dev_profile branch 4 times, most recently from adb4863 to 6a000ec Compare May 19, 2023 13:08
@decko decko closed this May 19, 2023
@decko decko reopened this May 19, 2023
Signed-off-by: André "decko" de Brito <decko@redhat.com>
@decko decko force-pushed the add_opentelemetry_dev_profile branch from 6a000ec to fb75fa4 Compare May 19, 2023 13:29
@decko decko merged commit 2cbc9ec into pulp:main May 19, 2023
@decko decko deleted the add_opentelemetry_dev_profile branch May 19, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a profile for telemetry dev env
6 participants