Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lower bounds tests requirements #60

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

mdellweg
Copy link
Member

[noissue]

@quba42
Copy link
Collaborator

quba42 commented Jul 31, 2023

Looks like the one test that is failing, is still looking for test_requirements.txt and not .lock.

@mdellweg
Copy link
Member Author

Looks like the one test that is failing, is still looking for test_requirements.txt and not .lock.

Somehow it reads the lowerbounds lock file, but it still uses an incompatible cython version to build PyYaml. Even switching to use it as a constraints file instead of requirements (I think i will keep that though.).

Bumps minimum required pulp-cli version to 0.18.2, because any older
version is uninstallable due to a PyYaml build bug.

[noissue]
@mdellweg
Copy link
Member Author

I do not know how i can restrict the build requirements of a requirement. So the only option i could see here is to bump the required pulp-cli version to >=0.18.2. Quite honestly, any older version is not installable anymore unless PyYaml releases a lot of backport fixes (and purges the broken ones).

@quba42 quba42 merged commit 490efd6 into pulp:main Aug 1, 2023
12 checks passed
@mdellweg mdellweg deleted the fix-lowerbounds-tests branch August 1, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants