Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The version checks need to understand app_labels of plugins and repository names as a fallback #153

Closed
mdellweg opened this issue Feb 18, 2021 · 1 comment · Fixed by #162
Closed

The version checks need to understand app_labels of plugins and repository names as a fallback #153

mdellweg opened this issue Feb 18, 2021 · 1 comment · Fixed by #162
Assignees
@bmbouter
Milestone
0.6.0

Comments

@mdellweg
Copy link
Member

mdellweg commented Feb 18, 2021 •
edited
Loading

pulp/pulpcore#1102
changes the way components are reported in the status and the api docs.
We need to change to use the new method and be able to still understand the old one.
@mdellweg mdellweg added this to the 0.5.0 milestone Feb 18, 2021
@mdellweg
Copy link
Member Author

To clarify, I mean, that the cli understands to digest the version information of older pulpcore installations.
On the user side we do not expose this so much (only pulp debug has-plugin), so i think we can get away with just requiring the the new names.

@mdellweg mdellweg mentioned this issue Feb 21, 2021
Merged
@daviddavis daviddavis modified the milestones: 0.5.0, 0.6.0 Feb 21, 2021
@bmbouter bmbouter self-assigned this Feb 22, 2021
bmbouter added a commit to bmbouter/pulp-cli that referenced this issue Feb 22, 2021
@bmbouter
Adds fallback names for plugin checking
320ce8d 
In pulpcore 3.11, the plugin names changed to fix a bug. This switches
the names of existing plugins to use the new names. It also adds
fallback support to allow pulpcore<3.11 names to continue working.

Fixes pulp#153
@bmbouter bmbouter mentioned this issue Feb 22, 2021
Merged
bmbouter added a commit to bmbouter/pulp-cli that referenced this issue Feb 22, 2021
@bmbouter
Adds fallback names for plugin checking
96e15b0 
In pulpcore 3.11, the plugin names changed to fix a bug. This switches
the names of existing plugins to use the new names. It also adds
fallback support to allow pulpcore<3.11 names to continue working.

Fixes pulp#153
bmbouter added a commit to bmbouter/pulp-cli that referenced this issue Feb 22, 2021
@bmbouter
Adds fallback names for plugin checking
da865ae 
In pulpcore 3.11, the plugin names changed to fix a bug. This switches
the names of existing plugins to use the new names. It also adds
fallback support to allow pulpcore<3.11 names to continue working.

Fixes pulp#153
bmbouter added a commit to bmbouter/pulp-cli that referenced this issue Feb 22, 2021
@bmbouter
Adds fallback names for plugin checking
7431a1f 
In pulpcore 3.11, the plugin names changed to fix a bug. This switches
the names of existing plugins to use the new names. It also adds
fallback support to allow pulpcore<3.11 names to continue working.

Fixes pulp#153
bmbouter added a commit to bmbouter/pulp-cli that referenced this issue Feb 22, 2021
@bmbouter
Adds fallback names for plugin checking
c8bc7ff 
In pulpcore 3.11, the plugin names changed to fix a bug. This switches
the names of existing plugins to use the new names. It also adds
fallback support to allow pulpcore<3.11 names to continue working.

Fixes pulp#153
bmbouter added a commit to bmbouter/pulp-cli that referenced this issue Feb 22, 2021
@bmbouter
Adds fallback names for plugin checking
60cd243 
In pulpcore 3.11, the plugin names changed to fix a bug. This switches
the names of existing plugins to use the new names. It also adds
fallback support to allow pulpcore<3.11 names to continue working.

Fixes pulp#153
bmbouter added a commit to bmbouter/pulp-cli that referenced this issue Feb 22, 2021
@bmbouter
Adds fallback names for plugin checking
7211ba6 
In pulpcore 3.11, the plugin names changed to fix a bug. This switches
the names of existing plugins to use the new names. It also adds
fallback support to allow pulpcore<3.11 names to continue working.

Fixes pulp#153
bmbouter added a commit to bmbouter/pulp-cli that referenced this issue Feb 24, 2021
@bmbouter
Adds fallback component names for plugin checking
93ab0ac 
In pulpcore 3.11, the component changed to fix a bug. This switches
the names of existing plugins to use the new names. It also adds
fallback support to allow pulpcore<3.11 names to continue working which
will be removed in a future release.

Additionally plugins can add in additional fallback names by adding to
the `new_component_names_to_pre_3_11_names` in the
`pulpcore.cli.common.context` module.

Fixes pulp#153
bmbouter added a commit to bmbouter/pulp-cli that referenced this issue Feb 24, 2021
@bmbouter
Adds fallback component names for plugin checking
350cdbe 
In pulpcore 3.11, the component changed to fix a bug. This switches
the names of existing plugins to use the new names. It also adds
fallback support to allow pulpcore<3.11 names to continue working which
will be removed in a future release.

Additionally plugins can add in additional fallback names by adding to
the `new_component_names_to_pre_3_11_names` in the
`pulpcore.cli.common.context` module.

Fixes pulp#153
bmbouter added a commit to bmbouter/pulp-cli that referenced this issue Feb 24, 2021
@bmbouter
Adds fallback component names for plugin checking
fe91b05 
In pulpcore 3.11, the component changed to fix a bug. This switches
the names of existing plugins to use the new names. It also adds
fallback support to allow pulpcore<3.11 names to continue working which
will be removed in a future release.

Additionally plugins can add in additional fallback names by adding to
the `new_component_names_to_pre_3_11_names` in the
`pulpcore.cli.common.context` module.

Fixes pulp#153
bmbouter added a commit to bmbouter/pulp-cli that referenced this issue Feb 24, 2021
@bmbouter
Adds fallback component names for plugin checking
33eb558 
In pulpcore 3.11, the component changed to fix a bug. This switches
the names of existing plugins to use the new names. It also adds
fallback support to allow pulpcore<3.11 names to continue working which
will be removed in a future release.

Additionally plugins can add in additional fallback names by adding to
the `new_component_names_to_pre_3_11_names` in the
`pulpcore.cli.common.context` module.

Fixes pulp#153
mdellweg pushed a commit that referenced this issue Feb 25, 2021
@bmbouter @mdellweg
Adds fallback component names for plugin checking
772c825 
In pulpcore 3.11, the component changed to fix a bug. This switches
the names of existing plugins to use the new names. It also adds
fallback support to allow pulpcore<3.11 names to continue working which
will be removed in a future release.

Additionally plugins can add in additional fallback names by adding to
the `new_component_names_to_pre_3_11_names` in the
`pulpcore.cli.common.context` module.

Fixes #153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmbouter bmbouter

Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Adds fallback component names for plugin checking bmbouter/pulp-cli
3 participants
@daviddavis @bmbouter @mdellweg