Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulp file content upload: --chunk-size option should allow unit specifier in arg #260

Closed
daviddavis opened this issue Jun 1, 2021 · 3 comments · Fixed by #349
Closed
Assignees
Labels
feature request New feature request (template-set)
Milestone

Comments

@daviddavis
Copy link
Contributor

From https://pulp.plan.io/issues/8838


Following up from IRC, this:

pulp file content upload --chunk-size

currently takes a value whose unit is assumed to be bytes.

For larger values, it would be extremely useful to allow a unit to be specified, such as 'k', 'm', 'g' (or, if you think differentiating between powers of 10 vs powers of 2 is important, an alternate specifier). A simple approach might be to match nginx (that's how I ran into this, after modifying the client_max_body_size option). I'm new to pulp, so I don't know what other examples there are within pulp.

@daviddavis daviddavis added the feature request New feature request (template-set) label Jun 1, 2021
@mdellweg
Copy link
Member

mdellweg commented Jun 1, 2021

In the meantime, you can use shell arithmetic $((2**22))=4M.

@ggainey
Copy link
Contributor

ggainey commented Jun 9, 2021

gerrod3 added a commit to gerrod3/pulp-cli that referenced this issue Aug 18, 2021
@gerrod3 gerrod3 self-assigned this Aug 19, 2021
gerrod3 added a commit to gerrod3/pulp-cli that referenced this issue Aug 26, 2021
gerrod3 added a commit to gerrod3/pulp-cli that referenced this issue Aug 26, 2021
ggainey pushed a commit that referenced this issue Aug 27, 2021
@ggainey ggainey added this to the 0.12.0 milestone Aug 27, 2021
@ggainey ggainey reopened this Aug 27, 2021
@ggainey
Copy link
Contributor

ggainey commented Aug 27, 2021

I'm an idiot, pushed the wrong button.

@ggainey ggainey closed this as completed Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request (template-set)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants