Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist on PyPI doesn't contain pulp_cli fake module #287

Closed
evgeni opened this issue Jun 30, 2021 · 0 comments · Fixed by #288
Closed

sdist on PyPI doesn't contain pulp_cli fake module #287

evgeni opened this issue Jun 30, 2021 · 0 comments · Fixed by #288
Milestone

Comments

@evgeni
Copy link
Member

evgeni commented Jun 30, 2021

#283 introduced a fake, non-namespaced module called pulp_cli which is needed to make old setuptools happy. sadly, this is only added to the distributed source when the tarball is built using such an old setuptools, which is usually not the case.

this results in the following error when trying to install from such an sdist:

error: package directory 'pulp_cli' does not exist
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue Jun 30, 2021
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue Jun 30, 2021
@mdellweg mdellweg modified the milestones: 0.10.0, 0.10.1 Jun 30, 2021
mdellweg added a commit that referenced this issue Jun 30, 2021
mdellweg added a commit that referenced this issue Jun 30, 2021
fixes #287

(cherry picked from commit 3d55bc9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants