-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user, I want to be able to disable certain plugins #291
Comments
We took the deliberate choice, that both help and shell_completion must not perform any call to the network, so having an option for "aware" installations is the way to go. I prefer an |
Also be aware, that within a plugin the cli might provide commands that will not work with the version of Pulp (core or plugin) you are running. |
I wonder if it makes sense to have a command that does call to the network that tells you which plugins the cli supports, which the server supports. With that info you can trivially build other lists:
Another factor may be compatibility between cli plugins and server plugins. |
@ekohl You inadvertantly raise an interesting point here: There is really no technical reason that a cli plugin is corresponding to a server plugin. |
I do think that a CLI plugin should declare somehow which server plugin it maps to (or core of course). |
I think, this can (and it almost is) be done on a per command (-group) basis. |
On reflection, this sounded to me like an anti-pattern for pulp-cli, given its design-goals of "can talk to multiple pulp-servers, all of which have different plugins and different versions". "You have plugin-X installed, but we want it turned off" makes sense for a "captive" env like Satellite...sort of. Even in that env, you might point your CLI to, say, a Capsule at a diff version, or a diff Satellite entirely. Trying to "turn off" specific plugins at the app level feels...wrong. HOWEVER - even assuming that, on reading through and thinking about the comments - I think there are valuable proposals here, esp things like cli-avail and server-avail. I don't have a design in my head for them, but I think we can use this issue to think about these kinds of requests. I was gonna close this issue, but I'm'a leave it open instead :) |
pulp-cli supports a variety of pulpcore plugins, but currently doesn't have a way to limit the CLI to the ones that are actually installed.
I am not sure whether querying the API before doing anything (including tab completion) is a good idea, but having a way to list plugins that shall be enabled (or disabled, I don't care too much), would be a good middle ground
That way Katello could deploy a config (after #290 is done) where we match the CLI plugins and the Server plugins :)
The text was updated successfully, but these errors were encountered: