Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orphan cleanup command raises deprecation warning #297

Closed
daviddavis opened this issue Jul 13, 2021 · 1 comment · Fixed by #318
Closed

Orphan cleanup command raises deprecation warning #297

daviddavis opened this issue Jul 13, 2021 · 1 comment · Fixed by #318
Labels
attention needed Extra attention from a maintainer is needed bug Something isn't working (template-set)
Milestone
0.11.0

Comments

@daviddavis
Copy link
Contributor

The pulp orphans delete command raises this deprecation warning (as of pulpcore 3.14):

pulpcore.deprecation:WARNING: The `DELETE /pulp/api/v3/orphans/` call is deprecated. Use`POST /pulp/api/v3/orphans/cleanup/` instead.

While we are fixing this command, I suggest we rename the command to pulp orphan cleanup as the current command is inconsistent with the rest of the CLI. We use singular resource names in the cli (eg pulp task list) and we don't use delete (rather destroy).
@mdellweg
Copy link
Member

This needs to be version aware.

@mdellweg mdellweg added attention needed Extra attention from a maintainer is needed bug Something isn't working (template-set) triaged labels Jul 21, 2021
@mdellweg mdellweg added this to the 0.11.0 milestone Jul 24, 2021
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue Jul 24, 2021
@mdellweg
Implement new orphan cleanup command
2973f76 
Deprecated the old orphans delete command and added a version dependent
switch to use the new pulpcore interface.

fixes pulp#297
@mdellweg mdellweg linked a pull request Jul 24, 2021 that will close this issue
Deprecations #318
Merged
mdellweg added a commit that referenced this issue Jul 25, 2021
@mdellweg
Implement new orphan cleanup command
828e87b 
Deprecated the old orphans delete command and added a version dependent
switch to use the new pulpcore interface.

fixes #297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
attention needed Extra attention from a maintainer is needed bug Something isn't working (template-set)
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Deprecations mdellweg/pulp-cli
2 participants
@daviddavis @mdellweg