Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tagging/untagging for container repositories #423

Closed
gerrod3 opened this issue Nov 11, 2021 · 2 comments · Fixed by #429
Closed

Add tagging/untagging for container repositories #423

gerrod3 opened this issue Nov 11, 2021 · 2 comments · Fixed by #429
Labels
feature request New feature request (template-set)
Milestone

Comments

@gerrod3
Copy link
Contributor

gerrod3 commented Nov 11, 2021

Summary

Both types of container repositories can be tagged and untagged. Should the commands be grouped under a tag subcommand under repository or just added as two separate commands?

Examples

pulp container repository tag --repository foo --name "custom_tag" --digest "manifest_digest"
pulp container repository -t push untag --repository phoo --name "another_tag"

or

pulp container repository tag add --repository foo --name "custom_tag" --digest "manifest_digest"
pulp container repository -t push tag remove --repository phoo --name "another_tag"

or maybe it's common enough to warrant it's own subgroup in container commands

pulp container tag add --repository foo --name "custon_tag" --digest "manifest_digest"
pulp container tag remove --repository push:phoo --name "another_tag"
pulp container tag list --repository foo overlaps with content -t tag list and repository content list -t tag

Tell me which command structure would be preferred.

@gerrod3 gerrod3 added the feature request New feature request (template-set) label Nov 11, 2021
@lubosmj
Copy link
Member

lubosmj commented Nov 12, 2021

I am good with the first option.

@ipanova
Copy link
Member

ipanova commented Nov 29, 2021

I'd go with option 1 since these are actions which are performed under the repository

gerrod3 added a commit to gerrod3/pulp-cli that referenced this issue Jan 20, 2022
gerrod3 added a commit to gerrod3/pulp-cli that referenced this issue Jan 27, 2022
gerrod3 added a commit to gerrod3/pulp-cli that referenced this issue Jan 28, 2022
gerrod3 added a commit to gerrod3/pulp-cli that referenced this issue Jan 28, 2022
gerrod3 added a commit to gerrod3/pulp-cli that referenced this issue Jan 28, 2022
gerrod3 added a commit to gerrod3/pulp-cli that referenced this issue Jan 28, 2022
mdellweg pushed a commit that referenced this issue Feb 2, 2022
@mdellweg mdellweg added this to the 0.14.0 milestone Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request (template-set)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants