Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulp rpm repository sync --no-optimize doesn't work #648

Closed
ggainey opened this issue Mar 7, 2023 · 0 comments · Fixed by #649
Closed

pulp rpm repository sync --no-optimize doesn't work #648

ggainey opened this issue Mar 7, 2023 · 0 comments · Fixed by #649
Assignees
@ggainey
Labels
bug Something isn't working (template-set)
Milestone
0.18.0

Comments

@ggainey
Copy link
Contributor

ggainey commented Mar 7, 2023

Summary

sync --no-optimize doesn't pass False to the server, because the check is "if optimize" instead of "if optimize is not None". --mirror/--no-mirror works only because the server-side default is "False".

See https://github.com/pulp/pulp-cli/blob/main/pulpcore/cli/rpm/repository.py#L222-L225
@ggainey ggainey added bug Something isn't working (template-set) Triage-Needed Needs to be reviewed at next pulp-cli mtg labels Mar 7, 2023
@ggainey ggainey self-assigned this Mar 7, 2023
ggainey added a commit to ggainey/pulp-cli that referenced this issue Mar 7, 2023
@ggainey
Fixed sync --no-optimize.
99637aa 
fixes pulp#648.
@ggainey ggainey mentioned this issue Mar 7, 2023
Merged
3 tasks
ggainey added a commit to ggainey/pulp-cli that referenced this issue Mar 7, 2023
@ggainey
Fixed sync --no-optimize.
81d38e4 
fixes pulp#648.
mdellweg pushed a commit that referenced this issue Mar 7, 2023
@ggainey @mdellweg
Fixed sync --no-optimize.
eff7950 
fixes #648.
@mdellweg mdellweg added this to the 0.18.0 milestone Mar 9, 2023
@mdellweg mdellweg removed the Triage-Needed Needs to be reviewed at next pulp-cli mtg label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggainey ggainey

Labels
bug Something isn't working (template-set)
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

Fixed sync --no-optimize. ggainey/pulp-cli
2 participants
@ggainey @mdellweg