Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulp-cli==0.20.0 installed using pip not compatible with click==8.1.4 #715

Closed
jakegatsby opened this issue Jul 6, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working (template-set) prio-list driving Pulp's Kanban searches

Comments

@jakegatsby
Copy link

Summary

pulpcore/cli/common/generic.py tries to do a from click.decorators import FC, F however it seems click==8.1.4 (released 2023-07-06) has removed F from decorators.py and pulp throws an ImportError

Steps to reproduce

python -m pip install pulp-cli==0.20.0
pulp

Expected behavior

No runtime exceptions when using the pulp cli

Stacktrace/Error log

...
...
  File "/opt/ansible/lib/python3.10/site-packages/pulpcore/cli/ansible/content.py", line 14, in <module>
    from pulpcore.cli.common.generic import (
  File "/opt/ansible/lib/python3.10/site-packages/pulpcore/cli/common/__init__.py", line 17, in <module>
    from pulpcore.cli.common.config import CONFIG_LOCATIONS, config, config_options, validate_config
  File "/opt/ansible/lib/python3.10/site-packages/pulpcore/cli/common/config.py", line 9, in <module>
    from pulpcore.cli.common.generic import pulp_group
  File "/opt/ansible/lib/python3.10/site-packages/pulpcore/cli/common/generic.py", line 10, in <module>
    from click.decorators import FC, F
ImportError: cannot import name 'F' from 'click.decorators' (/opt/ansible/lib/python3.10/site-packages/click/decorators.py)

Pulp and pulp-cli version info

pulp-cli==0.20.0
pulp-glue==0.20.0

Additonal context

@jakegatsby jakegatsby added bug Something isn't working (template-set) Triage-Needed Needs to be reviewed at next pulp-cli mtg labels Jul 6, 2023
@ggainey
Copy link
Contributor

ggainey commented Jul 7, 2023

Pulp's nightly CI is also very unhappy about this. Working on a fix right now, thanks for opening the issue for me!

@ggainey ggainey removed the Triage-Needed Needs to be reviewed at next pulp-cli mtg label Jul 7, 2023
@ggainey ggainey self-assigned this Jul 7, 2023
@ggainey ggainey added the prio-list driving Pulp's Kanban searches label Jul 7, 2023
@ggainey
Copy link
Contributor

ggainey commented Jul 7, 2023

We're going to need to back off to click-8.1.3, 8.1.4 and mypy linting (which we use) don't like each other much. See pallets/click#2558 for gory details.

decko added a commit to decko/pulp-cli that referenced this issue Jul 7, 2023
decko added a commit to decko/pulp-cli that referenced this issue Jul 7, 2023
decko added a commit to decko/pulp-cli that referenced this issue Jul 7, 2023
@ggainey ggainey closed this as completed in ca8e947 Jul 7, 2023
mdellweg pushed a commit that referenced this issue Jul 7, 2023
@ggainey
Copy link
Contributor

ggainey commented Jul 7, 2023

mdellweg pushed a commit that referenced this issue Jul 10, 2023
mdellweg pushed a commit that referenced this issue Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (template-set) prio-list driving Pulp's Kanban searches
Projects
None yet
Development

No branches or pull requests

2 participants