Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict requests<2.32 due to regressions #985

Closed
ggainey opened this issue Jun 12, 2024 · 0 comments · Fixed by #986
Closed

Restrict requests<2.32 due to regressions #985

ggainey opened this issue Jun 12, 2024 · 0 comments · Fixed by #986
Labels
bug Something isn't working (template-set) Triage-Needed Needs to be reviewed at next pulp-cli mtg

Comments

@ggainey
Copy link
Contributor

ggainey commented Jun 12, 2024

We allowed requests-2.32 in order to pick up the security-fix therein. Unfortunately, 2.32 is still not ready for primetime, with symptoms that are breaking our use of requests. We need to re-restrict until 2.32 stabilizes.

See https://hackmd.io/@pulp/CI_https_failures for research/discussion
@ggainey ggainey added bug Something isn't working (template-set) Triage-Needed Needs to be reviewed at next pulp-cli mtg labels Jun 12, 2024
ggainey added a commit to ggainey/pulp-cli that referenced this issue Jun 12, 2024
@ggainey
Revert "Bump the requests version"
c404825 
requests-2.32 isn't stable enough for our use yet.

This reverts commit cc1f17f.

fixes pulp#985
@ggainey ggainey mentioned this issue Jun 12, 2024
Merged
ggainey added a commit that referenced this issue Jun 12, 2024
@ggainey
Revert "Bump the requests version"
a002b96 
requests-2.32 isn't stable enough for our use yet.

This reverts commit cc1f17f.

fixes #985
patchback bot pushed a commit that referenced this issue Jun 12, 2024
@ggainey @patchback
Revert "Bump the requests version"
c857957 
requests-2.32 isn't stable enough for our use yet.

This reverts commit cc1f17f.

fixes #985

(cherry picked from commit a002b96)
@patchback patchback bot mentioned this issue Jun 12, 2024
Merged
ggainey added a commit that referenced this issue Jun 12, 2024
@ggainey
Revert "Bump the requests version"
20d2806 
requests-2.32 isn't stable enough for our use yet.

This reverts commit cc1f17f.

fixes #985

(cherry picked from commit a002b96)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working (template-set) Triage-Needed Needs to be reviewed at next pulp-cli mtg
Projects
No open projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Bump the requests version" ggainey/pulp-cli
1 participant
@ggainey