Update RPM commands for new 3.13 auto-publish #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrod3
force-pushed
the
rpm_autopublish_3.13
branch
2 times, most recently
from
fca3e71
to
e1f15d3
Compare
gerrod3
added a commit
to gerrod3/pulp_rpm
that referenced
this pull request
May 20, 2021
fixes: #8759 Required PR: pulp/pulp-cli#252
mdellweg
reviewed
May 21, 2021
| @@ -60,6 +60,7 @@ def distribution(ctx: click.Context, pulp_ctx: PulpContext, distribution_type: s | |||
| update_options = [ | |||
| click.option("--base-path"), | |||
| click.option("--publication"), | |||
| click.option("--repository", callback=_repository_callback), | |||
There was a problem hiding this comment.
This is def more than just adjusted tests.
There was a problem hiding this comment.
Well the option was missing, so I added it.
There was a problem hiding this comment.
And it's needed for the autopublish operations?
Then we can reflect this as a feature in the changelog. Like "Adjusted autopublish to new version of ...".
daviddavis
reviewed
May 24, 2021
CHANGES/251.bugfix
Outdated
| @@ -0,0 +1 @@ | |||
| Updated RPM auto-publish tests for future versions >=3.13.0.dev | |||
There was a problem hiding this comment.
The changelog is meant for end users so test changes don't need to be called out. I would probably just repurpose this for the repository option as @mdellweg suggests.
gerrod3
force-pushed
the
rpm_autopublish_3.13
branch
from
e1f15d3
to
c1e385f
Compare
gerrod3
changed the title
daviddavis
approved these changes
May 24, 2021
dralley
pushed a commit
to pulp/pulp_rpm
that referenced
this pull request
May 24, 2021
fixes: #8759 Required PR: pulp/pulp-cli#252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #251