Add string-or-file option. #400

ggainey · 2021-10-15T21:06:18Z

json_option is now built on top of this.

closes #220.

pulpcore/cli/common/generic.py

test_requirements.txt

mdellweg

I like this very much!
Idea for the future: Do we need an almighty callback class, that can naturally chain multiple transformers, validators and presenters together?

tests/scripts/pulp_file/mock.crt

json_option is now built on top of this. closes pulp#220.

ggainey · 2021-10-17T23:51:59Z

I like this very much! Idea for the future: Do we need an almighty callback class, that can naturally chain multiple transformers, validators and presenters together?

I have a vague image in my head of something like that, but nothing concrete enough to act on. As an example, I'm working on pulp_rpm things that would benefit from, say, a schema-check for json or xml. I'm def a big fan of keeping validation as close to the user as possible - anything we catch before a rest-call gets made is faster and puts less weight on the pulp instance. Def something to think about in our (copious) spare time :)

mdellweg · 2021-10-18T08:58:33Z

pulpcore/cli/common/generic.py

        try:
-            with click.open_file(json_file, "rb") as fp:
-                json_string = fp.read()
+            with click.open_file(the_file, "r") as fp:


Ha, I guess that makes thinking about bytes obsolete. Let's trust our tests, that we cover all use cases here.