-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of contains/startswith to RPM content #933
Conversation
Please squash the commits and add |
Thank you for this addition! |
Thanks @mdellweg for the review, please check again. |
One last request. ... and |
check again please thanks. |
Head branch was pushed to by a user without write access
@mdellweg pushed one additional change to move my test up a bit so that it doesn't interfere with the test OUTPUT in line 132 of file |
Can you add |
@stanleyz Sorry for the really long pause here, we lost sight of your contribution. I hope you don't mind, in the process of checking the failures I realized what the problem was, and submitted a fixed PR - #1040 starting from your commit. If you're ok with this, I'd like to close this PR and use #1040 to get this added. Let me know! |
Thanks @ggainey, feel free to go ahead, busy in other things, didn't look too much into this. |
Closing in preference for #1040 |
Review Checklist:
closes #687