Fix failing lint make target
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not ignore the D100 or D104 flake8 warnings. flake8-docstrings version 0.2.4 fixes this. From the changelog: > Fix bug introduced in 0.2.2 where the file source was always None causing D100 > and D104 errors for all files and no other errors to be found. Do ignore error D203, "1 blank line required before class docstring". See: https://gitlab.com/pycqa/flake8-docstrings/issues/8 Related to #46.
Pylint 1.5.0 and astroid 1.4.1 were released over the past weekend. Unfortunately, there are several regressions in the new releases. One such regression is a `UnicodeEncodeError` on Python 2, as documented here: https://bitbucket.org/logilab/astroid/issues/273 The regression has since been fixed, but no release has been made that includes the fix. Until the fix is made available via a release, force the use of older versions of pylint and astroid. Before this change: $ pip freeze | grep 'astroid\|pylint' astroid==1.4.1 pylint==1.5.0 After this change: $ pip freeze | grep 'astroid\|pylint' astroid==1.3.8 pylint==1.4.4 Related to #46.
|
Karma given |
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
lintmake target so it passes. See individual commit messages for more details.Fix #46.