Unable to handle urls with where the package name has + in the name

[rossengeorgiev]

Version

katello-4.4.1-1.el7.noarch
tfm-pulpcore-python3-pulp-deb-2.16.2-1.el7.noarch
tfm-rubygem-pulp_deb_client-2.16.0-1.el7.noarch

Describe the bug
One can argue that this is not a bug, but the repository works correctly under apt thus I consider it a bug.

Repo in question: https://packages.confluent.io/clients/deb

Error when attempting to sync:

404, message='Not Found', url=URL('https://packages.confluent.io/clients/deb/pool/main/c/confluent-libserdes/confluent-libserdes++1_8.0.0-1.cflt~ubu20_amd64.deb')

The error is caused by + not being encoded as %2B when making the request for the package. Tests with curl:

$ curl -I 'https://packages.confluent.io/clients/deb/pool/main/c/confluent-libserdes/confluent-libserdes++1_8.0.0-1.cflt~ubu20_amd64.deb'
HTTP/1.1 404 Not Found
Content-Type: application/xml
Connection: keep-alive
Date: Thu, 30 Jun 2022 15:28:04 GMT
Server: AmazonS3
X-Cache: Error from cloudfront
Via: 1.1 b92a7362e458b7339c38e84d8768135e.cloudfront.net (CloudFront)
X-Amz-Cf-Pop: MAN50-C3
Age: 7

$ curl -I 'https://packages.confluent.io/clients/deb/pool/main/c/confluent-libserdes/confluent-libserdes%2B%2B1_8.0.0-1.cflt~ubu20_amd64.deb'
HTTP/1.1 200 OK
Content-Type: application/x-debian-package
Content-Length: 17604
Connection: keep-alive
Date: Thu, 30 Jun 2022 15:28:20 GMT
Last-Modified: Fri, 24 Jun 2022 23:48:11 GMT
ETag: "48f1c14a12193754eb3ae198992e362e" 
Accept-Ranges: bytes
Server: AmazonS3
X-Cache: Miss from cloudfront
Via: 1.1 b5e57b301d7ec04bd5d65f7619eb0f34.cloudfront.net (CloudFront)
X-Amz-Cf-Pop: MAN50-C3

To Reproduce
See above

Expected behavior
Be able to sync the repository

Additional context
Copied from https://projects.theforeman.org/issues/35148

[quba42]

It looks like pulp_rpm has encountered and fixed the exact same issue. See here: https://github.com/pulp/pulp_rpm/blob/main/pulp_rpm/app/downloaders.py#L68

[quba42]

I have requested the pulp_rpm solution be transferred to pulpcore so we can also use it in pulp_deb. That being said, we don't need to wait for that to solve this on the pulp_deb side for now.

[rossengeorgiev]

Great work! Thanks