Fix source publish bug #1116
Merged
Fix source publish bug #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a source publishing bug where the code was looping through all release components instead of just the release components for the distribution when attempting to publish source files for a specific distribution component. This raised a key error that was found in @acheng-01's PR which added a test for source publishing: pulp#1061 [noissue]
daviddavis
force-pushed
the
fix-source-publish-bug
branch
from
8f2cc7a
to
ccd05a1
Compare
|
Thanks for identifying this! |
hstct
approved these changes
Jul 13, 2024
Backport to 3.2: 💚 backport PR created✅ Backport PR branch: Backported as #1131 🤖 @patchback |
Backport to 3.3: 💚 backport PR created✅ Backport PR branch: Backported as #1132 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
Fix source publish bug (cherry picked from commit 0a05615)
patchback bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
Fix source publish bug (cherry picked from commit 0a05615)
This was referenced Aug 6, 2024
quba42
added a commit
that referenced
this pull request
Aug 6, 2024
…9f6f15687268a1bccbac82ccc99332/pr-1116 [PR #1116/0a05615e backport][3.2] Fix source publish bug
quba42
added a commit
that referenced
this pull request
Aug 6, 2024
…9f6f15687268a1bccbac82ccc99332/pr-1116 [PR #1116/0a05615e backport][3.3] Fix source publish bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a source publishing bug that was introduced in b29542e where the code was looping through all release components instead of just the release components for the distribution when attempting to publish source files for a specific distribution component. This raised a key error that was found in @acheng-01's PR #1061 which added a test for source publishing.