Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add architecture=all consistent for simple and structured mode #200

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

Manisha15
Copy link
Contributor

No description provided.

@pulpbot
Copy link
Member

pulpbot commented Aug 19, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@quba42 quba42 added the .feature CHANGES/<issue_number>.feature label Aug 19, 2020
@Manisha15 Manisha15 force-pushed the architecture_all_consistent branch 2 times, most recently from 46484fb to 3815619 Compare August 25, 2020 07:19
@Manisha15 Manisha15 changed the title WIP: Add architecture=all consistent Add architecture=all consistent for simple and structured mode Aug 25, 2020
Copy link
Collaborator

@quba42 quba42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version seems to work as expected.
However, if I understand (https://wiki.debian.org/DebianRepository/Format#Architectures) correctly, we also need to make sure the string all is included in the Architectures field of our Release files.

See my comment below on how best to achieve that.

pulp_deb/app/tasks/publishing.py Outdated Show resolved Hide resolved
pulp_deb/app/tasks/publishing.py Outdated Show resolved Hide resolved
pulp_deb/app/tasks/publishing.py Outdated Show resolved Hide resolved
@quba42
Copy link
Collaborator

quba42 commented Aug 26, 2020

Looking good!

@quba42 quba42 merged commit caebe8d into pulp:master Aug 26, 2020
@quba42 quba42 deleted the architecture_all_consistent branch August 26, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.feature CHANGES/<issue_number>.feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants