Rework No-Support-for-Architecture-all repo format sync handling #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a bugfix for a bug introduced by the as of yet unreleased #422 ! |
quba42
force-pushed
the
no_support_for_architecture_all_filtering
branch
2 times, most recently
from
3249dc0
to
afb5f47
Compare
quba42
force-pushed
the
no_support_for_architecture_all_filtering
branch
2 times, most recently
from
08b67c5
to
5173c02
Compare
quba42
changed the title
quba42
commented
Mar 17, 2022
quba42
force-pushed
the
no_support_for_architecture_all_filtering
branch
from
5173c02
to
65453cd
Compare
m-bucher
approved these changes
Mar 17, 2022
mdellweg
reviewed
Mar 17, 2022
mdellweg
reviewed
Mar 17, 2022
mdellweg
reviewed
Mar 17, 2022
quba42
force-pushed
the
no_support_for_architecture_all_filtering
branch
5 times, most recently
from
89a5f89
to
9745d74
Compare
Closes pulp#456 pulp#456 When a repo uses "No-Support-for-Architecture-all: Packages" style format, we should not warn about all architecture packages in architecture specific package indices! They are expected to be there! We still skip those packages since there is no need to download them twice! When a mirror mirrors metadata indicating "No-Support-for-Architecture-all: Packages" format, while failing to mirror the binary-all package indices we introduce special handling to ensure we nevertheless sync "Architecture: all" packages. For more info, see: https://wiki.debian.org/DebianRepository/Format#No-Support-for-Architecture-all
quba42
force-pushed
the
no_support_for_architecture_all_filtering
branch
from
9745d74
to
04568ac
Compare
Backport to 2.17: 💚 backport PR created✅ Backport PR branch: Backported as #505 🤖 @patchback |
Backport to 2.16: 💚 backport PR created✅ Backport PR branch: Backported as #506 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 21, 2022
…filtering Rework No-Support-for-Architecture-all repo format sync handling (cherry picked from commit 536ce52)
patchback bot
pushed a commit
that referenced
this pull request
Apr 21, 2022
…filtering Rework No-Support-for-Architecture-all repo format sync handling (cherry picked from commit 536ce52)
quba42
added a commit
that referenced
this pull request
Apr 21, 2022
…filtering Rework No-Support-for-Architecture-all repo format sync handling (cherry picked from commit 536ce52)
quba42
added a commit
that referenced
this pull request
Apr 21, 2022
…filtering Rework No-Support-for-Architecture-all repo format sync handling (cherry picked from commit 536ce52)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #456
When a repo uses "No-Support-for-Architecture-all: Packages" style
format, we should not warn about all architecture packages in
architecture specific package indices! They are expected to be there!
We still skip those packages since there is no need to download them
twice!
When a mirror mirrors metadata indicating
"No-Support-for-Architecture-all: Packages" format, while failing to
mirror the binary-all package indices we introduce special handling to
ensure we nevertheless sync "Architecture: all" packages.