Rename cache_only to streamed #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
approved these changes
Dec 10, 2018
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Dec 12, 2018
The Settings can be a lot simpler now that the architecture no longer required redirection. It does need to account for the content being served on a different HOST. This PR handles that. Since the settings are now single values, they are much easier to override using Dynaconf, which is great. The content app can be removed now that the streamer code is handling it all. This PR is a prototype and has no docs. Use Pulp as normal , but run the streamer from github.com/bmbouter/pulp_streamer/ and run the streamer with: `gunicorn pulpcore.streamer:server --bind localhost:8080 --worker-class aiohttp.GunicornWebWorker -w 2` This PR needs pulp-smash changes from pulp_file so it requires the PR below: Required PR: pulp/pulp_file#140 https://pulp.plan.io/issues/4239 closes #4239
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Dec 12, 2018
The Settings can be a lot simpler now that the architecture no longer required redirection. It does need to account for the content being served on a different HOST. This PR handles that. Since the settings are now single values, they are much easier to override using Dynaconf, which is great. The content app can be removed now that the streamer code is handling it all. This PR is a prototype and has no docs. Use Pulp as normal , but run the streamer from github.com/bmbouter/pulp_streamer/ and run the streamer with: `gunicorn pulpcore.streamer:server --bind localhost:8080 --worker-class aiohttp.GunicornWebWorker -w 2` This PR needs pulp-smash changes from pulp_file so it requires the PR below: Required PR: pulp/pulp_file#140 https://pulp.plan.io/issues/4239 closes #4239 https://pulp.plan.io/issues/3698 closes pulp#3698 https://pulp.plan.io/issues/3699 closes pulp#3699 https://pulp.plan.io/issues/4181 closes #4181
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Dec 13, 2018
The Settings can be a lot simpler now that the architecture no longer required redirection. It does need to account for the content being served on a different HOST. This PR handles that. Since the settings are now single values, they are much easier to override using Dynaconf, which is great. The content app can be removed now that the streamer code is handling it all. This PR is a prototype and has no docs. Use Pulp as normal , but run the streamer from github.com/bmbouter/pulp_streamer/ and run the streamer with: `gunicorn pulpcore.streamer:server --bind localhost:8080 --worker-class aiohttp.GunicornWebWorker -w 2` This PR needs pulp-smash changes from pulp_file so it requires the PR below: Required PR: pulp/pulp_file#140 https://pulp.plan.io/issues/4239 closes #4239 https://pulp.plan.io/issues/3698 closes pulp#3698 https://pulp.plan.io/issues/3699 closes pulp#3699 https://pulp.plan.io/issues/4181 closes #4181 https://pulp.plan.io/issues/4243 closes #4243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/4243
re #4243