Problem: OpenAPI schema test is unreliable between different installs #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkliban
added a commit
to dkliban/pulpcore
that referenced
this pull request
Apr 4, 2019
Solution: Break up REST API docs into sections This patch modifies the OpenAPI schema. It introduces the concept of Tags. Each tag represents a type of resource in Pulp. E.g. Artifacts, Content, Remotes, Publishers, etc. This patch also improves the 'summary' field for each operation also. This is achieved with a new custom inspector class that drf_yasg can use to build the OpenAPI schema. This patch also adds a new 'restapi.html' page to the static docs. This new page uses ReDoc and the OpenAPI schema to display the REST API docs. Required PR: pulp/pulp_file#202 re: pulp#4104 https://pulp.plan.io/issues/4104
dkliban
force-pushed
the
update-openapi-schema
branch
3 times, most recently
from
5bb2f9e
to
c659595
Compare
dkliban
added a commit
to dkliban/pulpcore
that referenced
this pull request
Apr 4, 2019
Solution: Break up REST API docs into sections This patch modifies the OpenAPI schema. It introduces the concept of Tags. Each tag represents a type of resource in Pulp. E.g. Artifacts, Content, Remotes, Publishers, etc. This patch also improves the 'summary' field for each operation also. This is achieved with a new custom inspector class that drf_yasg can use to build the OpenAPI schema. This patch also adds a new 'restapi.html' page to the static docs. This new page uses ReDoc and the OpenAPI schema to display the REST API docs. Required PR: pulp/pulp_file#202 re: pulp#4104 https://pulp.plan.io/issues/4104
nixocio
approved these changes
Apr 4, 2019
dkliban
added a commit
to dkliban/pulpcore
that referenced
this pull request
Apr 4, 2019
Solution: Break up REST API docs into sections This patch modifies the OpenAPI schema. It introduces the concept of Tags. Each tag represents a type of resource in Pulp. E.g. Artifacts, Content, Remotes, Publishers, etc. This patch also improves the 'summary' field for each operation also. This is achieved with a new custom inspector class that drf_yasg can use to build the OpenAPI schema. This patch also adds a new 'restapi.html' page to the static docs. This new page uses ReDoc and the OpenAPI schema to display the REST API docs. Required PR: pulp/pulp_file#202 re: pulp#4104 https://pulp.plan.io/issues/4104
Solution: Remove the test re: #4104 https://pulp.plan.io/issues/4104
dkliban
force-pushed
the
update-openapi-schema
branch
from
c659595
to
f5a1d28
Compare
nixocio
approved these changes
Apr 4, 2019
dkliban
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Remove the test
re: #4104
https://pulp.plan.io/issues/4104