Adjust FileContentSerializer to upstream change #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
pushed a commit
to ATIX-AG/pulpcore
that referenced
this pull request
Sep 11, 2019
fixes #5428 https://pulp.plan.io/issues/5428 Required PR: pulp/pulp_file#273 Required PR: pulp/pulp-smash#1219
mdellweg
force-pushed
the
rename_content_serializer_fields
branch
4 times, most recently
from
12bee39
to
9fa458c
Compare
mdellweg
pushed a commit
to ATIX-AG/pulpcore
that referenced
this pull request
Sep 11, 2019
fixes #5428 https://pulp.plan.io/issues/5428 Required PR: pulp/pulp_file#273 Required PR: pulp/pulp-smash#1219
mdellweg
pushed a commit
to ATIX-AG/pulpcore
that referenced
this pull request
Sep 11, 2019
fixes #5428 https://pulp.plan.io/issues/5428 Required PR: pulp/pulp_file#273 Required PR: pulp/pulp-smash#1219
mdellweg
pushed a commit
to ATIX-AG/pulpcore
that referenced
this pull request
Sep 12, 2019
fixes #5428 https://pulp.plan.io/issues/5428 Required PR: pulp/pulp_file#273 Required PR: pulp/pulp-smash#1219
daviddavis
pushed a commit
to pulp/pulpcore
that referenced
this pull request
Sep 12, 2019
fixes #5428 https://pulp.plan.io/issues/5428 Required PR: pulp/pulp_file#273 Required PR: pulp/pulp-smash#1219
daviddavis
reviewed
Sep 12, 2019
CHANGES/5428.misc
Outdated
| @@ -0,0 +1 @@ | |||
| Adjust FileContentSerializer to upstream change. | |||
There was a problem hiding this comment.
This probably should be 5428.removal.
mdellweg
force-pushed
the
rename_content_serializer_fields
branch
from
9fa458c
to
4f3ac9f
Compare
|
I think this is failing because the PR branches it requires got deleted. Will have to remove the Required PRs from the commit I think. |
mdellweg
force-pushed
the
rename_content_serializer_fields
branch
from
4f3ac9f
to
e2a6be7
Compare
|
Let's try. |
|
@mdellweg I can work with you on merging this. Indeed, let's see if this works or not. |
|
These travis failures say |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #5428
https://pulp.plan.io/issues/5428