-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switches FileDistribution
use Distribution
#484
Switches FileDistribution
use Distribution
#484
Conversation
Attached issue: https://pulp.plan.io/issues/8387 |
11fc36f
to
6c18c6c
Compare
to='core.Distribution'), | ||
preserve_default=False, | ||
), | ||
migrations.RunPython(migrate_data_from_old_master_model_to_new_master_model), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really have the reverse_code here. I can do that in a follow up pr if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdellweg I'm not able to put it together due to time constraints, but I think it would be great if you'd be willing to post-merge. Like we talked about at the pulpcore meeting, doing it prior to the 3.12 release would be ideal because this migration is about to get replicated across almost all plugins very soon.
FYI much of the substantive discussion happened on this other PR, but there were issues with github "locking" my previous branch strangely so now we're using this PR. |
fa04dd3
to
5836a56
Compare
The tests are failing due to a mismatch of the pulp_file FilesystemExporter and the tests for it that live here. |
pulpcore==3.12 introduces a new MasterModel named `Distribution` designed to replace the `BaseDistribution` MasterModel. This PR switches the `FileDistribution` to use `Distribution`. It also ships a migration which moves the data from the `BaseDistribution` table to the `Distribution` field. Required PR: pulp/pulpcore#1198 closes #8387
5836a56
to
0173a20
Compare
pulpcore==3.12 introduces a new MasterModel named
Distribution
designed to replace the
BaseDistribution
MasterModel. This PR switchesthe
FileDistribution
to useDistribution
. It also ships a migrationwhich moves the data from the
BaseDistribution
table to theDistribution
field.Required PR: pulp/pulpcore#1198
closes #8387