Switches FileDistribution use Distribution
#484
Conversation
|
Attached issue: https://pulp.plan.io/issues/8387 |
bmbouter
force-pushed
the
switch-pulp-file-distribution-to-use-new-mastermodel
branch
4 times, most recently
from
11fc36f
to
6c18c6c
Compare
| to='core.Distribution'), | ||
| preserve_default=False, | ||
| ), | ||
| migrations.RunPython(migrate_data_from_old_master_model_to_new_master_model), |
There was a problem hiding this comment.
We should really have the reverse_code here. I can do that in a follow up pr if you prefer.
There was a problem hiding this comment.
@mdellweg I'm not able to put it together due to time constraints, but I think it would be great if you'd be willing to post-merge. Like we talked about at the pulpcore meeting, doing it prior to the 3.12 release would be ideal because this migration is about to get replicated across almost all plugins very soon.
|
FYI much of the substantive discussion happened on this other PR, but there were issues with github "locking" my previous branch strangely so now we're using this PR. |
bmbouter
force-pushed
the
switch-pulp-file-distribution-to-use-new-mastermodel
branch
2 times, most recently
from
fa04dd3
to
5836a56
Compare
|
The tests are failing due to a mismatch of the pulp_file FilesystemExporter and the tests for it that live here. |
pulpcore==3.12 introduces a new MasterModel named `Distribution` designed to replace the `BaseDistribution` MasterModel. This PR switches the `FileDistribution` to use `Distribution`. It also ships a migration which moves the data from the `BaseDistribution` table to the `Distribution` field. Required PR: pulp/pulpcore#1198 closes #8387
bmbouter
force-pushed
the
switch-pulp-file-distribution-to-use-new-mastermodel
branch
from
5836a56
to
0173a20
Compare
bmbouter
deleted the
switch-pulp-file-distribution-to-use-new-mastermodel
branch
pulpcore==3.12 introduces a new MasterModel named
Distributiondesigned to replace the
BaseDistributionMasterModel. This PR switchesthe
FileDistributionto useDistribution. It also ships a migrationwhich moves the data from the
BaseDistributiontable to theDistributionfield.Required PR: pulp/pulpcore#1198
closes #8387