Add domains compatiability #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
reviewed
Sep 15, 2022
pulp_file/app/models.py
Outdated
| @@ -37,10 +38,11 @@ class FileContent(Content): | |||
|
|
|||
| relative_path = models.TextField(null=False) | |||
| digest = models.CharField(max_length=64, null=False) | |||
| domain = models.ForeignKey("core.Domain", default=get_default_domain, on_delete=models.PROTECT) | |||
There was a problem hiding this comment.
Wouldn't we add this on the Content model?
[ ] Does not work with uniqueness constraints?
There was a problem hiding this comment.
Maybe we can add it as a constraint?
https://docs.djangoproject.com/en/3.2/ref/models/options/#django.db.models.Options.constraints
gerrod3
force-pushed
the
domains
branch
3 times, most recently
from
1647777
to
42a9821
Compare
gerrod3
force-pushed
the
domains
branch
4 times, most recently
from
af7155f
to
14dc957
Compare
mdellweg
reviewed
Mar 7, 2023
mdellweg
reviewed
Mar 7, 2023
pulp_file/tests/functional/api/from_pulpcore/test_content_path.py
Outdated
Show resolved
Hide resolved
mdellweg
reviewed
Mar 7, 2023
gerrod3
force-pushed
the
domains
branch
5 times, most recently
from
057c280
to
ea75c5a
Compare
fixes: #859
mdellweg
approved these changes
Mar 10, 2023
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required PR: pulp/pulpcore#3190
[noissue]