Validates that repository has a version to publish #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is validation, what about moving this into the serializer? |
|
We could do it this way. |
|
Is there a way to, inside the serializer, just set the "repository_version" and then only use that for the publish? That would be ideal. |
daviddavis
approved these changes
Apr 26, 2018
dralley
force-pushed
the
3587-versions-exist
branch
2 times, most recently
from
32c8d67
to
01e716f
Compare
Raise a ValidationError if you try to publish a repository which does not have any versions. closes #3583 https://pulp.plan.io/issues/3583
dralley
force-pushed
the
3587-versions-exist
branch
from
01e716f
to
80ad1b7
Compare
|
@daviddavis please re-review |
|
Works great. Thanks @dralley. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise a ValidationError if you try to publish a repository which
does not have any versions.
closes #3583
https://pulp.plan.io/issues/3583