Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Allows nginx to reverse proxy both services #132

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Allows nginx to reverse proxy both services #132

merged 1 commit into from
Aug 7, 2019

Conversation

bmbouter
Copy link
Member

@bmbouter bmbouter commented Aug 6, 2019

Without this urls outside of /pulp/content/ and /pulp/api/ would not
route correctly. This causes the last block to try both services if the
first one 404s.

https://pulp.plan.io/issues/4966
closes #4966

@bmbouter
Copy link
Member Author

bmbouter commented Aug 6, 2019

Here's how I test this by requesting 3 URLs.

First I request http localhost/pulp/api/v3/status/ and I see this in the logs:

Aug 06 19:45:33 pulp3-source-fedora28.localhost.example.com gunicorn[27775]: 127.0.0.1 - admin [06/Aug/2019:19:45:33 +0000] "GET /pulp/api/v3/status/ HTTP/1.0" 200 1330 "-" "HTTPie/0.9.4"

Notice it's on port 27775. Then I request http localhost/pulp/content/asdf/ and I see this in the logs:

Aug 06 19:45:51 pulp3-source-fedora28.localhost.example.com gunicorn[28294]: 127.0.0.1 [06/Aug/2019:19:45:51 +0000] "GET /pulp/content/asdf/ HTTP/1.0" 404 172 "-" "HTTPie/0.9.4"

Notice it's on port 28294. Then I request from one that isn't in /pulp/content/ or /pulp/api so I request http localhost/neither and I see this in the logs:

Aug 06 19:46:25 pulp3-source-fedora28.localhost.example.com gunicorn[27775]: pulp: django.request:WARNING: Not Found: /neither
Aug 06 19:46:25 pulp3-source-fedora28.localhost.example.com gunicorn[28294]: 127.0.0.1 [06/Aug/2019:19:46:25 +0000] "GET /neither HTTP/1.0" 404 172 "-" "HTTPie/0.9.4"
Aug 06 19:46:25 pulp3-source-fedora28.localhost.example.com gunicorn[27775]: 127.0.0.1 - admin [06/Aug/2019:19:46:25 +0000] "GET /neither HTTP/1.0" 404 77 "-" "HTTPie/0.9.4"

See how that url is requested from both backends by their port numbers!

Without this urls outside of /pulp/content/ and /pulp/api/ would not
route correctly. This causes the last block to try both services if the
first one 404s.

https://pulp.plan.io/issues/4966
closes #4966
Copy link
Member

@dkliban dkliban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmbouter bmbouter merged commit 4f42cf4 into pulp:master Aug 7, 2019
@bmbouter bmbouter deleted the additional-nginx-config branch August 7, 2019 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants