Add sync_mode parameter to endpoint that deploys sync task #159
Conversation
|
Just noticed #153 |
|
Use tags : P |
|
Looks like the revised changeset will have a sync_mode implementation. I will revise this PR to use that once it is merged, for now leaving as WIP |
pulp_python/app/viewsets.py
Outdated
| # Get sync_mode, default to additive | ||
| sync_mode = request.data.get('sync_mode', 'additive').lower() | ||
|
|
||
| if sync_mode not in ['mirror', 'additive']: |
There was a problem hiding this comment.
We should add a ChoiceField to the serializer, which will handle the validation for us. I already added choices as a constant.
https://github.com/pulp/pulp/blob/3.0-dev/common/pulpcore/common/constants.py#L30-L37
werwty
force-pushed
the
task3493
branch
2 times, most recently
from
6739b0e
to
cff7966
Compare
pulp_python/app/viewsets.py
Outdated
| @@ -156,13 +156,15 @@ def sync(self, request, pk): | |||
| ) | |||
| serializer.is_valid(raise_exception=True) | |||
| repository = serializer.validated_data.get('repository') | |||
| mirror = serializer.validated_data.get('mirror', True) | |||
There was a problem hiding this comment.
This value defaults to True in core, and that serializer is how this option is documented. So I think we shouldn't default here, since our default wouldn't be connected to the schema.
https://github.com/pulp/pulp/blob/cdf6133394d99bbc21a69fae4599d8271d6b344c/pulpcore/pulpcore/app/serializers/repository.py#L142
|
Thanks @CodeHeeler |
closes #3493
https://pulp.plan.io/issues/3493