Advisory Upload Support #1476
Merged
Advisory Upload Support #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @pavelpicka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-11-18 21:02:36 UTC |
pavelpicka
force-pushed
the
4012-errata-upload
branch
2 times, most recently
from
2941790
to
6078c2b
Compare
ipanova
reviewed
Nov 1, 2019
pavelpicka
force-pushed
the
4012-errata-upload
branch
2 times, most recently
from
a6f007c
to
29e48c5
Compare
|
Four times I removed 'allow_blank' as it was recent fix for ruby bindings, 'required=False' has same effect so no need to keep both. Bindings were tested. |
pavelpicka
force-pushed
the
4012-errata-upload
branch
from
29e48c5
to
3f48887
Compare
pavelpicka
force-pushed
the
4012-errata-upload
branch
7 times, most recently
from
1275772
to
2f1ed0e
Compare
|
Have you tested publish after adding reboot_suggested to the advisory level? |
pavelpicka
force-pushed
the
4012-errata-upload
branch
2 times, most recently
from
e08aacf
to
71fd476
Compare
it doesn't
we use createrepo_c for it (so I can't easily update publish with this field) |
pavelpicka
force-pushed
the
4012-errata-upload
branch
2 times, most recently
from
ae14b9d
to
803ccb6
Compare
ipanova
requested changes
Nov 18, 2019
pavelpicka
force-pushed
the
4012-errata-upload
branch
3 times, most recently
from
db1898f
to
81de07c
Compare
ipanova
reviewed
Nov 18, 2019
ipanova
reviewed
Nov 18, 2019
pavelpicka
force-pushed
the
4012-errata-upload
branch
from
81de07c
to
7040f70
Compare
ipanova
reviewed
Nov 18, 2019
|
@pavelpicka , where/how is digest calculated and set? |
pavelpicka
force-pushed
the
4012-errata-upload
branch
3 times, most recently
from
45fd8d9
to
1091029
Compare
Advisory can be uploaded via JSON file or already existing artifact (containing JSON). Models and serialzer extented to accept 'reboot_suggested' at advisory level. closes #4012 https://pulp.plan.io/issues/4012
pavelpicka
force-pushed
the
4012-errata-upload
branch
from
1091029
to
ab748df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advisory can be uploaded via JSON file or already existing artifact (containing JSON).
Model and serialzer extented to accept 'reboot_suggested' at advisory level.
closes #4012
https://pulp.plan.io/issues/4012