Ensure repo deletion doesn't fail due to the absence of listing files #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goosemania
commented
Jun 15, 2020
| try: | ||
| os.rmdir(up_dir) | ||
| except OSError: | ||
| # If this happened, there was a concurrency issue and it is no longer safe to | ||
| # remove the directory. It is possible that the concurrent operation created the | ||
| # listing file before this operation deleted it, so to be safe, we need to | ||
| # regenerate the listing file. | ||
| util.generate_listing_files(up_dir, up_dir) | ||
| try: | ||
| util.generate_listing_files(up_dir, up_dir) |
There was a problem hiding this comment.
Due to race condition, we can't safely fail earlier.
|
Attached issue: https://pulp.plan.io/issues/2826 |
daviddavis
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2826
https://pulp.plan.io/issues/2826