Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pulpcore 3.17 properly #2773

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Support pulpcore 3.17 properly #2773

merged 2 commits into from
Sep 13, 2022

Conversation

dralley
Copy link
Contributor

@dralley dralley commented Sep 13, 2022

No description provided.

@dralley dralley marked this pull request as ready for review September 13, 2022 12:57
Copy link
Member

@fao89 fao89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 7 to 10
if hasattr(settings, "V3_API_ROOT_NO_FRONT_SLASH"):
V3_API_ROOT = settings.V3_API_ROOT_NO_FRONT_SLASH
else:
V3_API_ROOT = "/pulp/api/v3/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I just changed this, I think the path fragment needs to not have a leading slash

@fao89 fao89 mentioned this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants