Add --force-full flag to publish command #849
Conversation
| date_filter = None | ||
|
|
||
| if last_published and \ | ||
| ((last_deleted and last_published > last_deleted) or not last_deleted): | ||
| ((last_deleted and last_published > last_deleted) or not last_deleted) and \ |
There was a problem hiding this comment.
Similar simplification of this if statement as suggested here: pulp/pulp#2548 (comment)
|
This branch has conflicts which need to be resolved. |
|
I'd like the comments addressed before merging, but I don't need a re-review. LGTM |
|
I've just noticed that even if last_publish is not None, it does not guarantee that the publish was a successful one. https://github.com/pulp/pulp/blob/master/server/pulp/plugins/conduits/repo_publish.py#L56-L57 But last_publish is used in pulp_rpm to decide if the publish should be an incremental one and also it is in a condition for no-op behavior in platform PR by @ipanova. It looks like it is not safe to rely on this date. What do you think? |
|
It turned out to be a wrong comment pulp/pulp#2551 |
If specified the full publication of the RPMs will be done even when it is possible to make an incremental one. closes pulp#1158 https://pulp.plan.io/issues/1158
If specified the full publication of the RPMs will be done even
when it is possible to make an incremental one.
closes #1158
https://pulp.plan.io/issues/1158