Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow looking up names using icontains, contains and startswith. #1071

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Allow looking up names using icontains, contains and startswith. #1071

merged 1 commit into from
Jan 14, 2021

Conversation

newswangerd
Copy link
Contributor

@newswangerd newswangerd commented Jan 14, 2021 •
edited
Loading

fixes #8094

bmbouter
bmbouter approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. A test would be nice, but it's mostly a feature we're configuring not creating so I'm ok w/ this.

@bmbouter
Copy link
Member

@fao89 what do you think?

mdellweg
mdellweg reviewed Jan 14, 2021
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.
Do we use this constant in all relevant places consistently?
TaskFilter, UserFilter and GroupFilter look like candidates. But the latter have also "iexact".

Should we export it to the plugin api?

@pulpbot
Copy link
Member

pulpbot commented Jan 14, 2021

Attached issue: https://pulp.plan.io/issues/8094

@fao89
Copy link
Member

fao89 commented Jan 14, 2021

@fao89 what do you think?

Looks good to me

@bmbouter
Copy link
Member

@dralley @daviddavis what do you think?

@bmbouter bmbouter merged commit 5a6d5c5 into pulp:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg left review comments

@daviddavis daviddavis daviddavis approved these changes

@bmbouter bmbouter bmbouter approved these changes

@dralley dralley dralley approved these changes

@fao89 fao89 fao89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@newswangerd @bmbouter @pulpbot @fao89 @daviddavis @dralley @mdellweg