Upgrade tests #1327
Upgrade tests #1327
Conversation
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
fao89
force-pushed
the
upgrade_tests
branch
8 times, most recently
from
fad31c6
to
fb28495
Compare
| echo "FROM_PULP_FILE_BRANCH=${{ matrix.FROM_PULP_FILE_BRANCH }}" >> $GITHUB_ENV | ||
| echo "FROM_PULPCORE_BRANCH=${{ matrix.FROM_PULPCORE_BRANCH }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
| cp -R /tmp/.github . | ||
| cp -R /tmp/.ci . | ||
| # Pin deps | ||
| sed -i "s/~/=/g" requirements.txt |
There was a problem hiding this comment.
Will this cause deps to not upgrade when the upgrade occurs? I'm not sure so I wanted to ask.
There was a problem hiding this comment.
we pin deps at CI time only for previous releases,
I did it for dealing with that django issue we had
There was a problem hiding this comment.
I see. So 3.11.2 will have that resolved (coming out in a few days) do you think we should merge this for now and undo it later or wait? I'm ok with either. If we're merging now how will we remember to remove this after 3.11.2 is out?
| @@ -94,6 +107,9 @@ fi | |||
| cd pulp-cli | |||
| pip install -e . | |||
| pulp config create --base-url http://pulp --location tests/settings.toml | |||
| sed -i "s/true/false/g" tests/settings.toml | |||
There was a problem hiding this comment.
I'm just curious what does this change?
There was a problem hiding this comment.
I use the CLI:
pulp status
pulp file content list
for showing plugin versions, so we can be sure the upgrade really happened, and for display it has content.
When I used that it tried https and broke!
Maybe we can have a better way to handle it, I don't know pulp-cli well
There was a problem hiding this comment.
oh yeah pulp-cli uses https as the default, so you're saying this is changing pulp-cli to use http instead of https.
| @@ -0,0 +1,136 @@ | |||
| # coding=utf-8 | |||
There was a problem hiding this comment.
These are no longer needed with python3
| """Create class-wide variables.""" | ||
| cls.cfg = config.get_config() | ||
|
|
||
| client = gen_file_client() |
| @@ -0,0 +1,124 @@ | |||
| # coding=utf-8 | |||
fao89
force-pushed
the
upgrade_tests
branch
2 times, most recently
from
e0c0f56
to
0b99fd7
Compare
fao89
force-pushed
the
upgrade_tests
branch
2 times, most recently
from
a26f180
to
27866a7
Compare
[noissue]
|
I believe this can be merged now |
[noissue]
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html