Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "remote" field from the BaseDistributionSerializer #133

Merged
merged 1 commit into from
May 14, 2019

Conversation

gmbnomis
Copy link
Contributor

@gmbnomis gmbnomis commented May 14, 2019

It should not be available by default, but only in those plugins that
implement pull-through caching.

closes #4817
https://pulp.plan.io/issues/4817

It should not be available by default, but only in those plugins that
implement pull-through caching.

closes pulp#4817
https://pulp.plan.io/issues/4817
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #133 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   67.15%   67.07%   -0.08%     
==========================================
  Files          64       64              
  Lines        3029     3028       -1     
==========================================
- Hits         2034     2031       -3     
- Misses        995      997       +2
Impacted Files Coverage Δ
pulpcore/app/serializers/publication.py 91.56% <ø> (-0.11%) ⬇️
pulpcore/app/serializers/task.py 98.07% <0%> (-1.93%) ⬇️
pulpcore/app/viewsets/task.py 97.01% <0%> (-1.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15e28bf...17201f0. Read the comment docs.

@dkliban dkliban merged commit 641f5e5 into pulp:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants