Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions & related docs updates #164

Merged
merged 3 commits into from
Jun 21, 2019
Merged

Conversation

mikedep333
Copy link
Member

1 commit resolves:

Document permissions for installation (without Ansible installer)

https://pulp.plan.io/issues/2881

The 2 other commits resolve the 2 other lack of documentation issues that I discovered while implementing it.

https://pulp.plan.io/issues/4918

https://pulp.plan.io/issues/4919

During manual (PyPI) install; before trying to run the Pulp services.

If the Pulp services don't fail to create them when running as root, they definitely will when running as a limited user.

https://pulp.plan.io/issues/4919
re pulp#4919
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #164 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   67.44%   67.37%   -0.07%     
==========================================
  Files          64       64              
  Lines        3056     3056              
==========================================
- Hits         2061     2059       -2     
- Misses        995      997       +2
Impacted Files Coverage Δ
pulpcore/app/serializers/task.py 98.07% <0%> (-1.93%) ⬇️
pulpcore/app/viewsets/task.py 97.01% <0%> (-1.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e422d31...a88b7ce. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #164 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #164      +/-   ##
=========================================
- Coverage   67.44%   67.4%   -0.04%     
=========================================
  Files          64      64              
  Lines        3056    3056              
=========================================
- Hits         2061    2060       -1     
- Misses        995     996       +1
Impacted Files Coverage Δ
pulpcore/app/serializers/task.py 98.07% <0%> (-1.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e422d31...a88b7ce. Read the comment docs.

Copy link
Contributor

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this looks good. Since you used re the automation won't mark them as MODIFIED. Plus, having issues in different commits (the commit separation is nice IMO) might cause the automation to miss some of them.

When you merge, please check that they are moved to MODIFIED and have the associated revisions.

@asmacdo asmacdo merged commit 2ccdc7d into pulp:master Jun 21, 2019
@mikedep333 mikedep333 deleted the permissions branch July 2, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants