Allow users to remove all content units from repo versions #172
Conversation
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
=========================================
- Coverage 67.38% 67.3% -0.08%
=========================================
Files 65 65
Lines 3078 3089 +11
=========================================
+ Hits 2074 2079 +5
- Misses 1004 1010 +6
Continue to review full report at Codecov.
|
daviddavis
force-pushed
the
issue4901
branch
2 times, most recently
from
9dce3cb
to
d62cd88
Compare
| write_only=True | ||
| ) | ||
| remove_content_units = serializers.ListField( | ||
| help_text=_('A list of content units to remove from the latest repository version'), | ||
| help_text=_("A list of content units to remove from the latest repository version. " |
There was a problem hiding this comment.
I imagined that ['*'] would be valid but ['someurlhere/UUID', '*'] to not be. It's not a big deal but since all other entries are ignored perhaps this should fail hard? what do you think?
There was a problem hiding this comment.
Done. Can you check out the change?
There was a problem hiding this comment.
@daviddavis ty for this PR! I can see that it will work as is. I left a few ideas w/ some optional suggestions. Since they are all optional I'll lgtm now and you can decide what we should do if that's ok.
There was a problem hiding this comment.
This looks great! Thanks @daviddavis I can see all the changes represented here.
fixes #4901
https://pulp.plan.io/issues/4901
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html