Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 403 Forbidden error case #10

Closed
chrsmith opened this issue Sep 26, 2017 · 6 comments
Closed

Improve 403 Forbidden error case #10

chrsmith opened this issue Sep 26, 2017 · 6 comments

Comments

@chrsmith
Copy link
Contributor

If you are not authorized to access the website (GitHub account authorized, but not on a whitelist) we should provide that information to the user. e.g. "You were not on any whitelisted GitHub organizations or email domains. Please contact chris@pulumi.com if you believe this is an error."

@chrsmith chrsmith added this to the 0.8 milestone Sep 26, 2017
@joeduffy
Copy link
Member

As an aside, a nicer 404 is probably worth considering. Shall I file a separate issue?

BTW, let's use support@pulumi.com for this, not your email address.

@chrsmith
Copy link
Contributor Author

Let's track both issues in this bug, though the fixes will require two very different approaches. Also, ack on the email address. Though I was hoping it would be my opportunity to look like a stock photo of somebody in tech support...

@chrsmith
Copy link
Contributor Author

From a conversation in the office:

  • We'll request user:email and read:org. So we can either do the email check or org whitelist.
  • Update the error message on the 403 page to indicate the user wasn't authorized, and should confirm they have a verified email address. Or contact their GitHub organization owner...
  • Having a specialized landing page to explain the "grant org access" would probably go a long way. e.g. /authorize-github-org with screen shots and an explanation for what the authorization is used for, etc.

@joeduffy
Copy link
Member

Given that we plan to flip this to public roughly after 0.9, is it worth doing anything here? I propose we just close this out and spend our energy building the real deal.

@joeduffy joeduffy removed this from the 0.8 milestone Oct 10, 2017
@lindydonna
Copy link
Contributor

Propose keeping this open in case we need it for a bigger private preview in Jan/Feb

@lindydonna
Copy link
Contributor

Proposing we close this. When we do the private beta, we can just document the symptom for customers.

Filed #72 for the 404 case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants