use pulumi CLI dev version for running CI #1535
Conversation
.github/workflows/cron.yml
Outdated
| @@ -43,7 +43,9 @@ jobs: | |||
| with: | |||
| dotnet-version: ${{matrix.dotnetversion}} | |||
| - name: Install Pulumi CLI | |||
| uses: pulumi/actions@v4 | |||
| uses: pulumi/actions@5ffa6249eba838c2a624d5315a28fb8c7b3dabb7 | |||
There was a problem hiding this comment.
Do we really want this pinned? Isn't latest v4 always going to be fine for us?
There was a problem hiding this comment.
It's pinned just to get the latest changes from pulumi/actions. We should probably do a release there so the latest v4 includes the changes to allow us to install the dev version.
We recently started publishing dev versions of the pulumi CLI. Use these for the CI builds in this repository, to give it some early exposure, and hopefully catch some bugs early.
tgummerer
force-pushed
the
tg/use-dev-version-for-ci
branch
from
6b97733
to
75d3c4a
Compare
|
We should also update https://github.com/pulumi/home/wiki/Producing-the-Pulumi-CLI-and-SDKs to say check https://github.com/pulumi/examples/actions/workflows/cron.yml is all green. (And work out why it's not green now) |
There was a problem hiding this comment.
I'd prefer that we not have this repo take a dependency on dev CLIs -- at least not without more discussion. If we want to use the examples in this repo for testing dev CLIs, we totally can, but we should do so with a separate workflow that's probably managed outside of this repo. Cloning this repo, for example, in a dedicated pulumi/pulumi GHA workflow job would probably give you what you're looking for.
|
@cnunciato happy to discuss this more! The idea here is to enroll repos in the pulumi org to use the dev version of pulumi/pulumi for running CI, so we can catch any potential user facing issues before they are getting released. It is especially helpful to this in this repository since it's one of the biggest collection of pulumi code. I would really like to keep these changes at least in the Note that I wouldn't expect "dev" versions to be much less stable than release versions currently are. They all go through the usual automated testing and review process before being merged and becoming a dev version. It's also what we cut a release from currently, and having an early indication of when anything is broken with our current build would be super helpful. This would also mean that the IaC Core team would start paying closer attention to these CI jobs, which would further help with the stability of them as well. All this said, I'd be happy to discuss this on slack or zoom as well if you prefer. |
Similar to pulumi/examples#1535, we would like to use the latest pulumi dev version here instead of just the latest version. In face in some places there was some (very outdated and non-functional) code to attempt that. Instead of the latest dev version it downloaded 3.40.0-alpha.1663101047 as of the time of this writing, which is less than ideal. Always use the dev version here unless we explicity request the "latest" version.
Similar to pulumi/examples#1535, we would like to use the latest pulumi dev version here instead of just the latest version. In face in some places there was some (very outdated and non-functional) code to attempt that. Instead of the latest dev version it downloaded 3.40.0-alpha.1663101047 as of the time of this writing, which is less than ideal. Always use the dev version here unless we explicity request the "latest" version.
Similar to pulumi/examples#1535, we would like to use the latest pulumi dev version here instead of just the latest version. In face in some places there was some (very outdated and non-functional) code to attempt that. Instead of the latest dev version it downloaded 3.40.0-alpha.1663101047 as of the time of this writing, which is less than ideal. Always use the dev version here unless we explicity request the "latest" version.
We recently started publishing dev versions of the pulumi CLI. Use these for the CI builds in this repository, to give it some early exposure, and hopefully catch some bugs early.