Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt breaking change in Helm chart API #194

Merged
merged 1 commit into from
Dec 15, 2018
Merged

Adopt breaking change in Helm chart API #194

merged 1 commit into from
Dec 15, 2018

Conversation

lukehoban
Copy link
Member

Adapt to changes in v0.18.0 from pulumi/pulumi-kubernetes#241.

Fixes #193.

@lukehoban
Copy link
Member Author

@ellismg Curious - do you think we should require that any examples that do not have tests avoid using latest? It feels like marking as latest is risky unless there are tests to catch breaking changes like this.

@lukehoban lukehoban merged commit dffb7cf into master Dec 15, 2018
@pulumi-bot pulumi-bot deleted the lukehoban/193 branch December 15, 2018 00:43
@hausdorff
Copy link
Contributor

Ugh, this is not good. If we keep latest, should we be compiling this during nightly build?

ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 7, 2019
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 13, 2019
dixler pushed a commit that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants