Add new Run method on PulumiTest #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrbradley
force-pushed
the
cache-stack-setup
branch
from
e2e640a
to
e25fced
Compare
thomas11
reviewed
Jan 8, 2024
danielrbradley
force-pushed
the
cache-stack-setup
branch
from
e25fced
to
4658401
Compare
- Make convert and copy follow the same default behaviour as the main test constructor. - Add log when creating a stack.
`CacheStackState` caches the stack state from executing the `run` func. Subsequent calls will load the stack state from the cache. - If the cache does not exist, it will run the `run` func and cache the resulting stack state. - The `run` function is always executed in an isolated temp directory so it won't affect the original test. - The state exported from the `run` function (or cached from the previous run) is imported into the original test's stack.
danielrbradley
force-pushed
the
cache-stack-setup
branch
from
4658401
to
03b0a26
Compare
- Make caching an optional feature within `Run`. - Fix bug in CopyToTempDir where options were not propagated.
- Re-use exists function from copy.go
danielrbradley
force-pushed
the
cache-stack-setup
branch
from
58a52b5
to
5184181
Compare
danielrbradley
changed the title
thomas11
approved these changes
Jan 9, 2024
Fix docs and logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #49
CacheStackStatecaches the stack state from executing therunfunc. Subsequent calls will load the stack state from the cache.runfunc and cache the resulting stack state.runfunction is always executed in an isolated temp directory so it won't affect the original test.runfunction (or cached from the previous run) is imported into the original test's stack.Aside: Fix missing install and stack creation in convert and copy