Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS m6a instances support #1791 #1792

Merged
merged 4 commits into from
Feb 4, 2022
Merged

AWS m6a instances support #1791 #1792

merged 4 commits into from
Feb 4, 2022

Conversation

minspresso
Copy link
Contributor

This PR is regarding issue #1791 - AWS m6a instances not supported

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

jkodroff
jkodroff approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@jkodroff jkodroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution!

@jkodroff
Copy link
Member

jkodroff commented Feb 2, 2022

/run-acceptance-tests

@jkodroff jkodroff added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Feb 2, 2022
@pulumi-bot
Copy link
Contributor

Please view the PR build -

@stack72
Copy link
Contributor

stack72 commented Feb 3, 2022

@jkodroff we need to build the schema to pick up these changes or we will have a failed build in main line

jkodroff
jkodroff suggested changes Feb 3, 2022
View reviewed changes
Copy link
Member

@jkodroff jkodroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Clamo Per Paul's comment above, I need to change my review to request changes. Could you run the following commands and resubmit your PR?

  • make tfgen
  • make build_sdks

This will allow the build to pass. Note that these commands may take a while to run - on the order of 10 minutes.

@jkodroff jkodroff mentioned this pull request Feb 3, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@jkodroff
Copy link
Member

jkodroff commented Feb 4, 2022

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

Please view the PR build -

@jkodroff jkodroff merged commit ce1add6 into pulumi:master Feb 4, 2022
@minspresso minspresso deleted the issue-1791 branch February 5, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkodroff jkodroff jkodroff approved these changes

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@minspresso @jkodroff @pulumi-bot @stack72