feat(classic): add GaugeWidget for cloudwatch dashboard #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
maniolias
force-pushed
the
feat/classic/gaugeWidget
branch
from
508c472
to
5437224
Compare
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
|
up 👍 |
mjeffryes
reviewed
Feb 29, 2024
There was a problem hiding this comment.
Looks reasonable to me. If you add a test to https://github.com/pulumi/pulumi-awsx/blob/master/awsx-classic/tests/cloudwatch/cloudwatch.spec.ts I think we can ship this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gauge Widget is missing on cloudwatch types. Here is a proposition of implementation