-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollout improved example converter #362
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Is README.md missing any configuration options?
Please add a description for each of these options to |
/// var exampleProject = new AzureDevOps.Project("exampleProject"); | ||
/// var example = new AzureDevOps.Project("example", new() | ||
/// { | ||
/// Name = "Example Project", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see many examples where the Name
property is now used. That's a behavior change since it turns off auto-naming and resources could conflict, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes indeed, this is tracked in pulumi/pulumi-converter-terraform#122 ; the previous behavior was better but we decided not to block on it.
Rolls out improved TF example converter.