Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout improved example converter #362

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Rollout improved example converter #362

merged 4 commits into from
Apr 19, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 16, 2024

Rolls out improved TF example converter.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

Is README.md missing any configuration options?

clientCertificate not found in Configuration section
clientCertificatePassword not found in Configuration section
clientCertificatePath not found in Configuration section
clientId not found in Configuration section
clientIdApply not found in Configuration section
clientIdPlan not found in Configuration section
clientSecret not found in Configuration section
clientSecretPath not found in Configuration section
oidcAudience not found in Configuration section
oidcRequestToken not found in Configuration section
oidcRequestUrl not found in Configuration section
oidcTfcTag not found in Configuration section
oidcToken not found in Configuration section
oidcTokenFilePath not found in Configuration section
tenantId not found in Configuration section
tenantIdApply not found in Configuration section
tenantIdPlan not found in Configuration section
useMsi not found in Configuration section
useOidc not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

/// var exampleProject = new AzureDevOps.Project("exampleProject");
/// var example = new AzureDevOps.Project("example", new()
/// {
/// Name = "Example Project",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see many examples where the Name property is now used. That's a behavior change since it turns off auto-naming and resources could conflict, isn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed, this is tracked in pulumi/pulumi-converter-terraform#122 ; the previous behavior was better but we decided not to block on it.

@t0yv0 t0yv0 requested a review from thomas11 April 17, 2024 15:46
@t0yv0 t0yv0 merged commit 9ef88d4 into master Apr 19, 2024
18 checks passed
@t0yv0 t0yv0 deleted the t0yv0/rollout-converter branch April 19, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants