Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make monitoring of node groups configurable #1032

Closed
maxemann96 opened this issue Feb 1, 2024 · 3 comments · Fixed by #1149
Closed

Make monitoring of node groups configurable #1032

maxemann96 opened this issue Feb 1, 2024 · 3 comments · Fixed by #1149
Assignees
@flostadler
Labels
impact/accessibility Something that is difficult or impossible for some people to use kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@maxemann96
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently it's not possible to alter the detailed logging switch in the underlying ec2 LaunchConfiguration / NodeLaunchTemplate, while managing the resource with this provider. Since we are monitoring our cluster with the Prometheus stack, we don't need the cloudwatch monitoring.

Affected area/feature

For Node.js, a change should be implemented starting here
@maxemann96 maxemann96 added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Feb 1, 2024
@mjeffryes mjeffryes added impact/accessibility Something that is difficult or impossible for some people to use and removed needs-triage Needs attention from the triage team labels Feb 2, 2024
@mjeffryes
Copy link
Member

Thanks for filing this @maxemann96. In the meantime, you might be able to manage this using transformations

@maxemann96
Copy link
Author

I forgot about transformations. Thanks for the info. Will use that as workaround.

@flostadler flostadler mentioned this issue May 15, 2024
Merged
flostadler added a commit that referenced this issue May 15, 2024
@flostadler
Add parameter for configuring monitoring options of NodeGroups (#1149)
a1e2711 
Expose parameter for configuring monitoring settings of NodeGroups.
With detailed monitoring, all metrics, including status check metrics,
are available in 1-minute intervals. When enabled, you can also get
aggregated data across groups of similar instances.

What's notable that this cannot be turned on for ManagedNodeGroups
because AWS doesn't expose controls for the underlying ASG
(aws/containers-roadmap#762)

Closes #1032
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label May 15, 2024
@maxemann96
Copy link
Author

Thanks for the implementation :)

flostadler added a commit that referenced this issue Sep 4, 2024
@flostadler
Add parameter for configuring monitoring options of NodeGroups (#1149)
2dbc2c9 
Expose parameter for configuring monitoring settings of NodeGroups.
With detailed monitoring, all metrics, including status check metrics,
are available in 1-minute intervals. When enabled, you can also get
aggregated data across groups of similar instances.

What's notable that this cannot be turned on for ManagedNodeGroups
because AWS doesn't expose controls for the underlying ASG
(aws/containers-roadmap#762)

Closes #1032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flostadler flostadler

Labels
impact/accessibility Something that is difficult or impossible for some people to use kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add parameter for configuring monitoring options of NodeGroups pulumi/pulumi-eks
4 participants
@mjeffryes @flostadler @maxemann96 @pulumi-bot