Only use the smart default for AMI at creation time. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehoban
commented
Apr 24, 2019
nodejs/eks/package.json
Outdated
| @@ -11,9 +11,9 @@ | |||
| "homepage": "https://pulumi.io", | |||
| "repository": "https://github.com/pulumi/pulumi-eks", | |||
| "dependencies": { | |||
| "@pulumi/aws": "^0.18.0", | |||
| "@pulumi/aws": "dev", | |||
There was a problem hiding this comment.
I will update this to a released build before merging.
metral
approved these changes
Apr 24, 2019
When we use the "smart default" to pick the most recent EKS-optimized AMI, we now also mark the image as `ignoreChanges` to ensure that we do not pick up new "smart defaults" later. Users can still explicitly specify an `amiID`, and if they do this will also remove the `ignoreChanges` annotation so that the change will be applied. Fixes #88.
flostadler
pushed a commit
that referenced
this pull request
Sep 4, 2024
When we use the "smart default" to pick the most recent EKS-optimized AMI, we now also mark the image as `ignoreChanges` to ensure that we do not pick up new "smart defaults" later. Users can still explicitly specify an `amiID`, and if they do this will also remove the `ignoreChanges` annotation so that the change will be applied. Fixes #88.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use the "smart default" to pick the most recent EKS-optimized AMI, we now also mark the image as
ignoreChangesto ensure that we do not pick up new "smart defaults" later. Users can still explicitly specify anamiID, and if they do this will also remove theignoreChangesannotation so that the change will be applied.Fixes #88.